Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

core.error() does not fail the workflow

See original GitHub issue

According to https://github.com/actions/toolkit/tree/main/packages/core#annotations this code should fail the build: core.error('Fatal error'). It does not. The workflow succeeds.

jobs:
  fail:
    runs-on: ubuntu-latest
    steps:
      - name: Fail workflow
        uses: actions/github-script@v6.0.0
        with:
          script: core.error('Fatal error')

I can see the annotation on the actions page but not on the pull request page. Also I get a green checkmark indicating that the workflow was successfull.

Issue Analytics

State:
Created 2 years ago
Comments:6 (2 by maintainers)

Top GitHub Comments

1reaction

T3rm1commented, Jun 10, 2022

Yes, it does.

1reaction

joshmgrosscommented, Jun 10, 2022

@T3rm1 does this work if you use core.setFailed instead?

/**
 * Sets the action status to failed.
 * When the action exits it will be with an exit code of 1
 * @param message add error issue message
 */
export function setFailed(message: string | Error): void {
  process.exitCode = ExitCode.Failure

  error(message)
}

https://github.com/actions/toolkit/blob/b5f31bb5a25d129441c294fc81ba7f92f3e978ba/packages/core/src/core.ts#L208-L217