Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Action does not match folders starting with dot (.)

See original GitHub issue

Actual:

if I have a change in a folder src/.deploy and matcher for src/**/* it would not be matched.

Expected:

folders starting with dot should be matched as well.

It seems the issue is related to how Minimatch works. See https://github.com/isaacs/minimatch/issues/30 . Consider passing {dot: true} by default.

Issue Analytics

State:
Created 2 years ago
Reactions:14
Comments:9

Top GitHub Comments

9reactions

kachkaevcommented, Nov 30, 2022

Today we were configuring labels in blockprotocol/blockprotocol and I was like ‘oh no not this dot problem again’ 😅

So here is the fix: https://github.com/actions/labeler/pull/316. It is non-breaking, just allows us to set the dot input:

 name: "Pull Request Labeler"
 on:
 - pull_request_target

 jobs:
   triage:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/labeler@v3
       with:
+        dot: true
         repo-token: "${{ secrets.GITHUB_TOKEN }}"

I hope it will become available for everyone soon! 🤞

3reactions

kachkaevcommented, Feb 4, 2022

How about adding a new action param to make the fix non-breaking?

    - uses: actions/labeler@v3
      with:
        repo-token: "${{ secrets.GITHUB_TOKEN }}"
+       dot: true

Happy to work on the PR if anyone reading this comment has capacity to review it and cut a release. Alternatively, we can just add { dot: true } to minimatch and release version 4.

Our current .github/labeler.yml in hashintel/hash is pretty long because of this issue:

packages/foo:
  - packages/foo/*
  - packages/foo/.*
  - packages/foo/**/*
  - packages/foo/**/.*

# ↑ repeat ×20

😔

Top Results From Across the Web

grep ignores files starting with dot [duplicate]

From man grep : -d ACTION \n If an input file is a directory, use ACTION to process it. By default, ACTION is...

Match dot files recursively using regex - Stack Overflow

I started with: ^[.] But this does not match the case of long/path/here/.dotfile . Also it ...

4. Pattern Matching with Regular Expressions - Java ... - O'Reilly

Returns the character position in the string of the starting and ending characters that matched. groupCount(): Returns the number of parenthesized capture ...

glob - Greg's Wiki

It should be noted that when dotglob is enabled, * will match files like .bashrc but not the . or .. directories. This...

DOT Rule 49 CFR Part 40 Section 40.83

Subpart F - Drug Testing Laboratories § 40.83 How do laboratories process ... The specimen ID numbers on the specimen bottle and the...