Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Automatic discovery of version matching package.json engines

See original GitHub issue

Description:

In my organization we pin specific version of Node in package.json via engines.node.

https://docs.npmjs.com/cli/v7/configuring-npm/package-json#engines

It therefore seems redundant to include such information in the CI.

I would prefer the action to allow - if the appropriate package.json is detected - to look in engines.node in package.json and select the latest NodeJS version that meets the specified version range. This would be complementary to the current versioning mechanism and only have an effect if the version is not specified as an action parameter.

Justification:

DRY

Are you willing to submit a PR?

I would like discuss it first.

Issue Analytics

State:
Created a year ago
Reactions:11
Comments:5 (2 by maintainers)

Top GitHub Comments

1reaction

dmitry-shibanovcommented, Oct 3, 2022

Hello everyone. We released a new version with support for engines.node. You can try to specify package.json for node-version-file input to grad version from engines.node.

0reactions

xrlcommented, Dec 7, 2022

@dmitry-shibanov it worked for me! Thanks!