ESLint doesn't exit on failOnError();

So I’m creating gulp tasks dynamically like this

var gulp           = require('gulp');
var eslint         = require('gulp-eslint');
var apps           = require('../config').browserify;
var createPaths    = require('../helpers/create-paths');
var lintTasks      = [];
var watchLintTasks = [];

var lint = function( project ) {
    return function() {
        var srcFiles = createPaths.watchPath(project, 'js');

        return gulp.src(srcFiles)
            .pipe(eslint())
            .pipe(eslint.format())
            .pipe(eslint.failOnError());
    };
};

apps.map(function(app){
    lintTasks.push('lint:' + app);
    watchLintTasks.push('watch:lint:' + app);

    gulp.task('lint:' + app, lint(app));
    gulp.task('watch:lint:' + app, function(){
        gulp.watch(createPaths.watchPath(app, 'js'), ['lint:'+ app]);
    });
});

gulp.task('lintScripts', lintTasks);
gulp.task('watch:lintScripts', watchLintTasks);

And then in my build task I’m running gulp.task('build', ['lintScripts', ...]);

When I run gulp build it doesn’t exit on errors I tried many solutions from #12 but still not exiting when it fails any idea how to fix this?

[MatthewHerbst]

I’m having this same issue when running the lint task from a watch task.

In my gulpfile.js

gulp.task('lint:server', lintServer);

function lintServer() {
  return gulp.src([paths.app.server])
      .pipe(eslint())
      .pipe(eslint.format())
      .pipe(eslint.failAfterError());
}

function watchServer() {
  gulp.watch([paths.app.server], ['lint:server']);
}

The command lint reruns, but doesn’t even report, let alone exit on, errors.

[adametry]

It looks like you’re running your lint and build tasks in parallel. If you want tasks to wait for the lintScripts task to pass (and not run if it fails), make sure those tasks are dependent on lintScripts (gulp will keep.

Here’s an example of tasks running in (dependency) sequence:

// ...after the lintTasks are prepared
gulp.task('lintScripts', lintTasks, function () {
     console.log('All lint tasks succeeded');
});

gulp.task('postLintTask', ['lintScripts'], function () {
    console.log('running post-link task now...');
});

gulp.task('build', ['lintScripts','postLintTask'], function () {
    console.log('running build task now...');
});

Otherwise, your code works fine for me (with a bit of a guess at what createPaths.watchPath does); though, because all the linting happens in parallel, the process may get more than one error before exiting with a code of 1. One way to control that is to merge the the streams between eslint() and eslint.format() (can provide detail, if interested).