The automatic windows parameter doesn't work for powershell scripts

Version(s)

10.0.0

To reproduce

Steps to reproduce the behaviour:

1. Add a SimpleExec.RunAsync(“myscript.ps1”).
2. Execute
3. Observe failure “An error occurred trying to execute”

Expected behaviour

I would loosely expect this new automatic behavior to play nice with ps1 files, and possibly other windows scripting files (e.g., vbs, js)?

Actual behaviour

System.ComponentModel.Win32Exception (193): An error occurred trying to start process 'C:\0\repos\LRS-CSharp-Build\src\LRS.CSharp.Build\tools\win32\bin\dotnet-install.ps1' with working directory 'C:\0\repos\LRS-CSharp-Build'. The specified executable is not a valid application for this OS platform.

Workarounds

Add a wrapper if/else to make the main executable powershell.exe, which was technically possible when windowsName was available but now that it isn’t I have to add my own if block.

[mockjv]

@adamralph Ok, sorry for the confusion. I could have sworn I’d seen a commit where changes were reverted but I must be losing my mind or I was looking at the wrong thing. I completely understand your concerns regarding the added complexity in your library, so no worries here!

[adamralph]

it looks like your considering re-introducing that argument

@mockjv as I said in my previous comment (to which you reacted with 👍), I’m leaning towards not providing any special in SimpleExec here, and leaving it to the caller to make the command name and args conditional on the OS, etc.

Note that ps1 is not treated as “executable” in Windows. The only way to “execute” a ps1 file in Windows is to pass it as an argument to powershell.exe (or rely on file extension association to do that for you). So when using SimpleExec to execute a ps1 file, the correct way to do that is:

await RunAsync("powershell", "foo.ps1 bar baz");

If you are running something else on Linux or macOS then you need make your code conditional on the OS. E.g.

await Command.RunAsync(
    RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? "powershell" : "foo",
    $"{(RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? "foo.ps1" : "")} bar baz");

I acknowledge that you were using the windowsName and windowsArgs parameters for this purpose before:

await Command.RunAsync("foo", "bar baz",
    windowsName: "powershell",
    windowsArgs: "foo.ps1 bar baz");

But I’m not convinced that code is much nicer, not least because you have to pass the “non-script” arguments "bar baz" to both the args and windowsArgs parameters, and therefore I’m not convinced it’s worth maintaining that more complex API in SimpleExec for this purpose.