Replace Legacy .zip packaging with the new DualityTemplates .zip packaging

Summary

Right now, the NightlyBuilder will pack a binary .zip that will no longer be usable with the v4.0 pre-release. It will show up as a CI artifact and could otherwise confuse any future maintainers or users. This can be fixed by replacing it with the new DualityTemplates .zip that is generated on build.

Analysis

• Remove all legacy .zip code from NightlyBuilder, e.g. this block, this block and all related config variables.
• Remove the legacy AdditionalFiles folder and related config entries, and some more. This will leave the nightly builder with only build, test, .chm docs and package steps remaining as-is.
• Update the CI artifact path for the template download .zip to point to the new template .zip - or adjust the output path of the templates project to match it.

Simplifying NightlyBuilder as outlined above will also make it a little easier to talk about retiring NightlyBuilder altogether because there’s less moving parts left to identify for replacement.

[Barsonax]

Its not meant for archival purposes because they clean it after 6 months 😃.

I believe the max artifact storage capacity is around 50GB (in case its not enough they are even willing to increase) so we would need alot of builds happening in 6 months to fill this up. Probably still best to just put a branch condition on it (only master/release) but commenting it out shouldn’t be necessary.

I never ran into problems with this as most CI’s auto clean after a while. Just don’t assume the files are there forever.

Some advantages:

• Always/more often running the packaging/artifacts steps means they are being tested more often thus less prone to silently breaking.
• Easier to see what artifacts a build is gonna produce before releasing it.

EDIT: Its about 13MB per build (the duality zip is now alot smaller since it no longer has binaries) with 50GB that means we need to have almost 4000 builds happening within 6 months. Considering that duality doesnt even have that much commits during its entire history I don’t think we will ever reach that much so might as well just publish artifacts on every build. https://ci.appveyor.com/project/AdamsLairBot/duality/builds/33459842/artifacts

[Barsonax]

Will look into this the coming week