Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Link on li vs anchor text?

See original GitHub issue

Thank you for this great package. Thoughts on moving the link to the <li> vs the <a>? I have had a few users tell me the pagination is broken because they are clicking on the page box vs the page number. I can create a PR if others see value in the change.

Issue Analytics

State:
Created 6 years ago
Comments:5 (1 by maintainers)

Top GitHub Comments

2reactions

ghostcommented, Nov 21, 2017

I 2nd this. At the least the a tags should get the padding from the li tags, so the clickable area is larger.

It looks like this was done on purpose in version 4.0 and above by @AdeleD : https://github.com/AdeleD/react-paginate/commit/c85c086e51e6931f983904a0fa9255fd517f2a44

@AdeleD was that to enhance accessibility?

1reaction

grbsplttcommented, Feb 2, 2018

I’m closing this. While I (and one other person who has since deleted their comment) do not believe CSS is the correct way to handle this, I myself do not believe there is consensus here that anything needs to be fixed. I’ll tell my users they aren’t using it properly and they should pound sand.