Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Investigating tying `sp-dropdown` and `sp-action-menu` into overlay system

See original GitHub issue

Expected Behaviour

Content should be available on top of everything!

Actual Behaviour

Some content can flow over the dropdown/action-menu content.

Reproduce Scenario (including but not limited to)

Put content after the dropdown or action-menu with a very high z-index…

Possibilities

This may be manageable by adding a fallback to the overlay system that hoists overlay content to the <body/> when and overlay-root is not available. Further research should go into whether popover, which powers these elements, should deliver this feature by default.

Issue Analytics

State:
Created 4 years ago
Comments:10

Top GitHub Comments

1reaction

cuberootcommented, Sep 18, 2019

So, here’s what some of my teammates hit when trying to use the dropdown.

ScreenFlow

It is rendering underneath the surrounding screen elements and the clicks are going to elements underneath (an sp-checkbox)

0reactions

benjamindcommented, Dec 16, 2019

@Westbrook can you elaborate more on option 1 here? I’m not sure I quite understand the need to do slot flattening.

Surely if the slotted content in the dropdown element (i.e. the sp-menu) is attached as content payload to the sp-overlay:open event then there’s no need to do any additional walking of the dom to gather slotted nodes? You’re just taking the top level content that was slotted into the dropdown.