Failed migrations are not rolled back

Migrations should be run in transactions, just like in Knex, and they should be rolled back on failure.

My migration file is very simple…

const Schema = use('Schema')

class DocumentsSchema extends Schema {
  up () {
    this.create('documents', (table) => {
      table.increments()
      table.integer('user_id').unsigned().index().references('id').inTable('users')
    })
  }

  down () {
    this.drop('documents')
  }
}

module.exports = DocumentsSchema

I ran node ace migration:run. The migration failed with Cannot add foreign key constraint but the table was not deleted aka the transaction was not rolled back. The migration error itself is fine, but why wasn’t the migration rolled back?

Discord discussion:

[simontabor]

After the failed migration, I just ran node ace migration:rollback and it ran ALL (~50) of the down() migrations (e.g. deleted 20 tables). After a successful migration this doesn’t happen, so something is clearly wrong here.

[moltar]

MySQL is unable to transact DDL statements.

https://dev.mysql.com/doc/internals/en/transactions-notes-on-ddl-and-normal-transaction.html