Lifecycle hooks are called even thought the transaction is not committed yet

Hi!

We are working on a AdonisJS + Algolia integration, the package is meant to be public in the end.

We have an issue with transaction and lifecycle hooks, maybe you can give us a hint? Here is the log of the issue in a adonis repl:

mobile.club[development] > o = await Order.find(1819)
undefined

mobile.club[development] > DB = use('Database')
DatabaseManager {
  Config:
   Config {
     _configPath: '/Users/iam4x/mobile.club/workspace/packages/api/config',
     _config:
      { algolia: [Object],
        app: [Object],
        auth: [Object],
        bodyParser: [Object],
        cors: [Object],
        database: [Object],
        drive: [Object],
        mail: [Object],
        redis: [Object] } },
  _connectionPools:
   { pg: Database { connectionClient: 'pg', knex: [Function], _globalTrx: null } } }

// Creating Transaction
mobile.club[development] > trx = await DB.beginTransaction()
undefined

// Doing stuff into the transaction
mobile.club[development] > await o.transitionTo('order_awaiting_shipment', {}, trx)

// ---->> WRONG??
// afterUpdate is called (re-index into Algolia)
afterUpdate
{
    "id": 1819,
    "customer_id": 1818,
    "country_id": 1,
    "coupon_id": null,
    "code": "MAR0100718",
    "shipping_address": {
        "zip": "XXX",
        "city": "XXX",
        "extra": "XXX",
        "street": "XXX"
    },
    "billing_address": {
        "zip": "XXX",
        "city": "XXX",
        "street": "XXX",
        "country": "XXX"
    },
    "note": null,
    "activated_at": null,
    "deleted_at": null,
    "created_at": "2018-07-04 16:22:35",
    "updated_at": "2018-08-07 16:45:18",
    "is_business_order": false,
    "company_name": null,
    "company_registration_number": null,
    "active": false,
    "recurly_subscription_uuid": "XXX",
    "algolia_object_id": "XXXX"
}
afterUpdate
{
    "id": 16,
    "customer_id": 1818,
    "created_at": "2018-07-05 18:03:19",
    "updated_at": "2018-08-07 16:45:18",
    "algolia_object_id": "XXX"
}
afterUpdate
{
    "id": 1818,
    "email": "XXX",
    "first_name": "XXX",
    "last_name": "XXX",
    "phone": "XXX",
    "created_at": "2018-07-04 16:22:35",
    "updated_at": "2018-08-07 16:45:18",
    "gender": "f",
    "accepted_marketing_at": "2018-07-05T16:05:44.111Z",
    "accepted_cgl_at": "2018-07-05T16:05:44.111Z",
    "accepted_cgu_at": "2018-07-05T16:05:44.111Z",
    "accepted_contract_at": "2018-07-05T16:05:44.111Z",
    "birthdate": "1963-11-12T23:00:00.000Z",
    "invite_sent": true,
    "algolia_object_id": "XXX",
    "is_password_set": true,
    "has_completed_order": true,
    "__meta__": {
        "has_completed_order": true
    }
}
true

// Commit the transaction actual changes saved into dabase
// No lifecycle hooks are triggered at this time
mobile.club[development] > await trx.commit()
{ sql: 'COMMIT;',
  bindings: undefined,
  response:
   Result {
     command: 'COMMIT',
     rowCount: null,
     oid: null,
     rows: [],
     fields: [],
     _parsers: [],
     RowCtor: null,
     rowAsArray: false,
     _getTypeParser: [Function: bound ] } }

So two questions:

• Is this fixable? Since knex is handling transactions and not lucid.
• If not, would it be possible to have an afterTransaction? Or to get the transaction in the afterXXX hooks so we can do our stuff after it.

Thanks again for the amazing work on AdonisJS 💘

cc @othierry my co-worker on this!

[thetutlage]

@othierry Nice to hear that.

I also thought something similar to what you shared, but de-coupled from models.

1. Everytime you call Database.beginTransaction, the trx instance should allow you to define lifecycle hooks to it.

trx.onCommit(callback, data)
trx.onRollback(callback, data)

Now inside models you can simply attach to these hooks.

class User extends Model {
  static boot () {
    super.boot()

    this.addHook('afterSave', function (modelInstance) {
      if (modelInstance.hasTransaction()) {
        modelInstance.getTransaction().onCommit()
        modelInstance.getTransaction().onRollback()
      }
    })
  }
}

onCommit(callback, data)

When transaction commits, the callback is executed with the data as 1st argument.

onCommit(function (data) {
  // transaction commited
}, modelInstance)

onRollback(callback, data)

When transaction rollback, the callback is executed with the data as 1st argument.

onCommit(function (data) {
  // transaction commited
}, modelInstance)

[thetutlage]

Okay another one Laravel repo and one related to their official Algolia package scout

I have some general design idea in my mind. I will do an RFC on same and will drop the link here.