History renamed compared to tf1 wrapper

I’m mostly through migration to this great project, as part of the move to upgrade to tf2 and noticed that history is called history_ in scikeras. This is documented in the Model documentation but it might be nice to have a note in the migration guide.

As there are some PRs related to this history object I won’t make a suggestion for the doc as I don’t know how the behaviour changes (for my case it is just a case of renaming).

[adriangb]

Hi @icfly2 thank you for the issue.

I think the old wrappers returned a history object from calling fit instead of saving it is .history or .history_. So I don’t think we renamed the parameter, instead we changed the signature of fit and saved the history as an attribute instead. Please let me know if I am missing anything here 😄

But I do think we should added this to our transition guide. I don’t think it made it on there because it was a change done so early in the development of SciKeras (when it was a PR in TensorFlow) that we didn’t even have a transition guide 😅 .

[stsievert]

@icfly2 from the Keras.fit docs, it appears this code works:

import keras
hist = keras.fit(...)
hist.history

However, SciKeras is slightly different:

from scikeras.wrappers import KerasClassifier
est = KerasClassifier(...)
est.fit(...)
# est = est.fit(...)  # or this line
est.history_

Is that what this issue is about?