Open handle after unsuccessful call to `.connect` keeps process running

If a call to .connect fails, the module prevents the process from exiting gracefully and a call to process.exit is needed, which should not be the case.

[jhecking]

Definitely a difference. When calling .close on the same reference of the client I call the (then failing) .connect on, the process is kept alive. When I extract the client out of the error and call .close on that, the process does exit as expected.

Hmm, that’s interesting. I cannot reproduce that behavior using this simplified test case:

const as = require('aerospike')
const client = new as.Client({ hosts: '127.0.0.1:8888'})
client.connect().catch((error) => {
  console.error(error.message)
  client.close()
})

After closing the client instance the process terminates immediately in my case.

PRs to improve the documentation are always welcome! The AerospikeError docs already mention about the referenced client instance and the fact that it can be used to close the connection in the case of errors: https://www.aerospike.com/apidocs/nodejs/AerospikeError.html#client. (Generated from lib/error.js.) But probably this is not very discoverable and there might be other places where this information is missing?

[jhecking]

The referenced client object should be the same. Let me know if calling client.close() does not release all event loop handles either in your case. Btw, what client version are you using?