Prevent or notify broken master tests
See original GitHub issueWhat is the Problem Being Solved?
We recently had some build check failures for master:
https://github.com/Agoric/agoric-sdk/runs/5069159963?check_suite_focus=true
lerna ERR! EPUBLISHCONFLICT Cannot publish @agoric/cosmos@undefined over existing version.https://github.com/Agoric/agoric-sdk/runs/5069182650?check_suite_focus=true
error @typescript-eslint/parser@5.10.2: The engine "node" is incompatible with this module. Expected version "^12.22.0 || ^14.17.0 || >=16.0.0". Got "14.15.5" error Found incompatible module.
They persisted for some days because there was no notification. The checks that were failing were defined for some purpose, so we should know when they fail (or if it doesn’t matter then remove them).
Description of the Design
TBD, some way to prevent persistent failures of master checks.
Security Considerations
–
Test Plan
TBD
Issue Analytics
- State:
- Created 2 years ago
- Comments:18 (18 by maintainers)
Top Results From Across the Web
Maturing the Test Profession Towards True Quality Assurance
Testers Can Prevent Defects Too – Maturing the Test Profession Towards True Quality Assurance · Key moments. View all · Key moments ·...
Read more >How to avoid broken master with Pipelines for Merged Results ...
Broken master. This can happen when CI pipelines run on the master branch, but don't pass all tests. A red cross mark is...
Read more >How to auto-reject a pull request if tests are failing (Github ...
The best way to "reject" the pull request is to prevent it from being merged unless the tests pass.
Read more >Notifications for workflow runs - GitHub Docs
The notification will include the workflow run's status (including successful, failed, neutral, and canceled runs). You can also choose to receive a ...
Read more >What is Smoke Testing? Build Verification Tests Explained ...
By design, smoke tests do not cover every permutation and edge case. They instead check that your application isn't so broken that additional ......
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found

Gotcha. An alternative is to modify workflows that trigger on master to send a notification (email, keybase, etc) on failure.
@michaelfig might be able to take the first one.
I probably broke the second one.