Remove Prettier from eslint

What is the Problem Being Solved?

https://github.com/Agoric/agoric-sdk/pull/4330#discussion_r789387409

Description of the Design

• Remove prettier concern from eslint
• anyone relying on the eslint autofix can enable formatOnSave with https://github.com/Agoric/agoric-sdk/blob/master/scripts/configure-vscode.sh
• Add prettier check to CI
• yarn lint-fix in each package should still fix formatting (cc @kriskowal @warner )

Security Considerations

n/a

Test Plan

• prettier problems don’t appear in IDE
• pretty-check failures fail CI

[mhofman]

Any reason people can’t update their IDEs to run both eslint and prettier fix on save? VSCode should do prettier by default. I actually don’t like having eslint fix on by default as that’s usually more invasive changes, but I understand some may want to have it. The code hint overload can be real between all these tools.

Btw, do we know if the eslint-prettier plugin respects the // prettier-ignore instruction?

[turadg]

Just ran into something else that would improve by removing this: eslint warnings in Github UI:

@FUDCo doesn’t want any format-on-save and his draft PRs aren’t meant to pass CI. The Prettier warnings clutter reading the code and provide no useful information.