IllegalStateException: getDatabase called recursively in Migration even when using databaseWrapper

DBFlow Version: 4.1.2

Bug or Feature Request: Recursive Database call

Description: I’m using the Database wrapper to perform a select during a migration (in order to set the value of one column to the value of an associated column), and even though I’m using the Database wrapper provider in migrate() I am getting an IllegalStateException saying that the database is being accessed recursively.

Here’s what I’m doing (in Kotlin):

@Migration(version = 3, database = AppDatabase::class)
class Migration3 : BaseMigration() {
    override fun migrate(database: DatabaseWrapper) {

        val messages = SQLite.select().from(Message::class).queryList(database)

        messages.forEach {
            (update<Message>()
                    set Message_Table.folder_path.eq(it.folder?.path)
                    where Message_Table.messageId.eq(it.messageId))
                    .execute(database)
        }
    }
}

[agrosner]

in 5.0.0-alpha1 this has been fixed. code gen now resembles as follows:

 @Override
  public final Artist_Song loadFromCursor(FlowCursor cursor, DatabaseWrapper wrapper) {
    Artist_Song model = new Artist_Song();
    model._id = cursor.getLongOrDefault("_id");
    int index_song_id_Song_Table = cursor.getColumnIndex("song_id");
    if (index_song_id_Song_Table != -1 && !cursor.isNull(index_song_id_Song_Table)) {
      model.song = SQLite.select().from(Song.class).where()
          .and(Song_Table.id.eq(cursor.getInt(index_song_id_Song_Table)))
          .querySingle(wrapper);
    } else {
      model.song = null;
    }
    int index_artist_id_Artist_Table = cursor.getColumnIndex("artist_id");
    if (index_artist_id_Artist_Table != -1 && !cursor.isNull(index_artist_id_Artist_Table)) {
      model.artist = SQLite.select().from(Artist.class).where()
          .and(Artist_Table.id.eq(cursor.getInt(index_artist_id_Artist_Table)))
          .querySingle(wrapper);
    } else {
      model.artist = null;
    }
    return model;
  }

we pass in db wrapper everywhere and is pretty much a requirement in every db method now.

[agrosner]

closing as its fixed.