Custom Annotation Aliases

Provide an API to allow users to register their own annotations to be aliases to default ACF annotations + Configurations: Flags, Conditions, CommandPermission, Subcommand

Something like

manager.registerAnnotation(CustomAnnotation.class, Conditions.class, "conditionname:conditionconfig");
manager.registerParameterAnnotation(ParameterType.class, CustomAnnotation.class, Conditions.class, "conditionname:conditionconfig");
manager.registerParameterAnnotation(ParameterType.class, CustomAnnotation.class, Flags.class, "flagconfig=flagvalue");

Then using @CustomAnnotation will be same as putting

@Conditions("conditionname:conditionconfig") @Flags("flagconfig=flagvalue")

on a parameter or method

I will be personally working this issue, not looking for PR’s on it.

[kumpelblase2]

Have you considered using meta-annotations (so using annotations on annotations) for this instead? Not to mention, basic support would be trivial to implement (given the current state of the code):

In Annotations.java#L53 if we change this:

- Annotation annotation = object.getAnnotation(annoClass);
+ Annotation annotation = getAnnotationRecursive(object, annoClass);

and define that function like so:

    private static Annotation getAnnotationRecursive(AnnotatedElement object, Class<? extends Annotation> annoClass) {
        if(object.isAnnotationPresent(annoClass)) {
            return object.getAnnotation(annoClass);
        } else {
            for (Annotation otherAnnotation : object.getDeclaredAnnotations()) {
                final Annotation annotationRecursive = getAnnotationRecursive(otherAnnotation.annotationType(), annoClass);
                if(annotationRecursive != null) {
                    return annotationRecursive;
                }
            }
        }
        return null;
    }

it would already find the necessary annotations. So we could implement your given example like this:

@Retention(RetentionPolicy.RUNTIME)
@Conditions("conditionname:confitionconfig")
@Flags("flagconfig=flagvalue")
public @interface CustomAnnotation {}

(The only additional thing that would be needed to change for @Flags to work like in the example is to allow that annotation to be present on annotation types, which it currently isn’t allowed to. @Conditions would already work like this.)

This is used quite extensively in Spring/Spring Boot (a little bit of reference here), though Spring goes quite a bit further (for example, also allowing for properties of the combined annotation to alias for properties on the composing annotations).

[aikar]

yes and no, work is actively being done in master for it.