resolve RefreshableCredentials.token issue

we currently disable the token property because it needs to be an async call. See: https://github.com/aio-libs/aiobotocore/blob/master/aiobotocore/credentials.py#L259

This is called in places like SigV4Auth._modify_request_before_signing which is called by SigV4Auth.add_auth. I haven’t check upstream who calls this yet

[thehesiod]

wow didn’t expect so much time dedicated to this, hehe, awesome. I ran into this because we’re migrating to opensearch which apparently requires SigV4Auth, just created some aiohttp helpers for that, maybe will make some time to make a module for that. I’d post it on a gist but then someone will snarf it before I create a module 😉

[terrycain]

Ok from what I can see. The only place SigV4Auth is instantiated is in the AUTH_TYPE_MAPS dict in auth.py, and the only place it’s values are accessed would be in signers.py, which we’ve supplied the credentials as get_frozen_credentials() so calling self.credentials.token should be safe as it should be an instance of ReadOnlyCredentials.

In theory if calling get_frozen_credentials on one of the credential providers doesn’t return a ReadOnlyCredentials object then it would cause issues. Don’t suppose you can send me some info on how to recreate it.