Rule 3.6 (use property value shorthand) leads to refactoring errors

Consider the following code…

const url = 'http://some-service.com/';
const data = { foo: 'bar' };
$.ajax({ url, data });

One day you decide that “apiUrl” is a better name so you rename the variable and end up with…

const apiUrl = 'http://some-service.com/';
const data = { foo: 'bar' };
$.ajax({ apiUrl, data });

And now you have an error. My example may seem a little contrived but it’s pretty common to have options parameters in javascript. At some point your variables names might happen to align with the option names, but it’s usually just a coincidence.

What is your opinion on this?

[philippevk]

Anyway, it’s not a big deal as I can simply disable the rule for my project. I just wanted to let you know of the issue. Whether you support this use case is your decision!

[ljharb]

Personally I’d report it as a bug in the IDE’s auto-refactoring mechanism rather than disabling a useful rule 😃 but as always, you’re quite welcome to override whatever rules you wish!