Upgrade Okio to 2.x

We are writing an a Kotlin app that uses Lottie and OkHTTP. We are considering replacing Lottie due to the project’s reliance on Okio 1.x. This causes a circular dependency that is caught by Gradle when using OkHTTP 4.x and Lottie in the same project. I see that about a year ago the project added a comment // Do not ugprade to 2.0 because it will bring in Kotlin as a transitive dependency. to the project’s build.gradle. Has anything changed?

Steps to reproduce the behavior:

1. Clone https://github.com/mozilla-mobile/fenix
2. Change the mockwebserver value to a current 4.x release. ex: 4.5.0
3. Compile debug app
4. Circular dependency error from the compiler. OkHTTP wants Okio 2.x and Lottie wants Okio 1.x

https://github.com/mozilla-mobile/fenix/issues/8169#issuecomment-600231224

[kbrosnan]

Looking at okio’s 2.0.0-rc1 release notes page they have the following notes about migrating from 1.x to 2.x

Okio 2 is a major release that upgrades the library’s implementation language from Java to Kotlin.

Okio 2.x is binary-compatible with Okio 1.x and does not change any behavior. Classes and .jar files compiled against 1.x can be used with 2.x without recompiling.

Okio 2.x is .java source compatible with Okio 1.x in all but one corner case. In Okio 1.x Buffer would throw an unchecked IllegalStateException when attempting to read more bytes than available. Okio 2.x now throws a checked EOFException in this case. This is now consistent with the behavior of its BufferedSource interface. Java callers that don’t already catch IOException will now need to.

Okio 2.x is .kt source-incompatible with Okio 1.x. This release adopts Kotlin idioms where they are available. [omitted list of idioms, see link to full release notes]

[mstange]

Doesn’t the circular dependency issue still exist?