Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Handle private @Preview annotations gracefully

See original GitHub issue

When trying to build a project with private Previews, Showkase complains:

The methods annotated with Preview can't be private as Showkase won't be able to access them otherwise

Does it have to be an error? Not all previews are Showkase-worthy, some of them can be used just in ide. Maybe it could be a warning or there could be a gradle flag for this? Wdyt? This should be relatively easy, I could contribute if you decide that it’s a good idea to add it.

Issue Analytics

State:
Created a year ago
Comments:11

Top GitHub Comments

4reactions

micHarcommented, Aug 23, 2022

Yes, seems like a better idea to warn than to crash. Generally I would agree with you when it comes to the fail fast principle, but here it feels like showkase should be an addition and not hijack the original process. Alternatively maybe a compiler flag or sth to disable this behavior so that we don’t have to use showkase annotations on composables which are not meant for showkase at all.

1reaction

vinaygabacommented, Sep 5, 2022

@iamutkarshtiwari Yeah I’m surprised I had not added that already. I plan to fix this issue this week and I will improve the error logging as well so that you know the source of the error.