Modification Cornucopia

Hi. I recently used ts-migrate, in conjunction with my own codemod runner, to migrate large portions of my codebase to TS. It was fun!

Along the way, I made a series of modifications to make ts-migrate work for my repo. Some of them are likely specific to my idiosyncrasies, but some may be generally applicable. I’ll list them here, and you can tell me which, if any, you’re interested in. I’ll then carve individual PRs for the pieces you want.

Change List

Here’s the full set of changes, but it’s a bit noisy because some of it is things I’d never recommend merging / it’s not cleaned up for you. So I’ll also link to individual commits in the list below, but it’s not always a 1:1 mapping 🤪 .

• Upgrade from TS 4.2 to TS 4.6
• Reignore: Add ability to specify a custom message for inserted ts-expect-error comments
• Reignore: Add ability to skip the eslint fix step
• Reignore: Add ability to skip the “strip ts-ignore” step
• Rename: Pass back a list of files that were modified. I used this for downstream tooling that would do further processing on those files.
• ts-migrate-server: Fix bug where absolute paths were treated as relative paths
• ts-migrate-server: Return a list of modified files
• Rename: “Improve” JSX detection
• Rename: Don’t rename foo.js to foo.ts if a foo.d.ts already exists.

Anyway, lmk if you’re interested in any of this. 😄

Task Tracking

Completed Changes

• TS update to 4.7 – looks like someone got there before me. 😄

[NickHeiner]

Cool – I’ll probably have time to do some of these PRs in a month or so. Or anyone else is welcome to make an attempt in the meantime. 😄

Also, I recently ran into issues that I think are attributable to a stale tsbuildinfo after updating the compilerOptions in tsconfig. This may account for some instances where ts-migrate inserted ts-expect-errors unnecessarily, or failed to insert some that were needed. I don’t have a bulletproof repro yet, but it may be safer for ts-migrate to delete tsbuildinfo before building the TS project, to avoid any such risks.

[devinrhode2]

@NickHeiner all those setup steps ran without warnings or errors, but when I finally ran yarn run ts-migrate locally, it was as if ts-migrate was not actually installed.

I did have success using verdaccio instead:

npm install --global verdaccio@6-next
verdaccio

Publish forked package locally:

git clone https://github.com/devinrhode2/ts-migrate.git ts-migrate-devin
cd ts-migrate-devin
git checkout nth/tvui-modifications-rebased-by-devin
yarn install
yarn run bootstrap
yarn run build
npm adduser --registry http://localhost:4873
YARN_REGISTRY=http://localhost:4873 yarn lerna publish

finally:

YARN_REGISTRY=http://localhost:4873 yarn add ts-migrate --dev