Icevision no longer works with the latest `sahi` release
See original GitHub issue🐛 Bug
Describe the bug
Icevision stopped working with the latest sahi
release (0.11.0).
When trying to do: from icevision.all import *
I get: ModuleNotFoundError: No module named 'sahi.model'
Looking at the code, I see the following:
sahi.model import DetectionModel
However, in the latest sahi
release, the module structure contains a models
subfolder, not model
. For instance, in their predict.py
script, there is the following:
from sahi.models.base import DetectionModel
One can look at their new folder/package structure here.
Two possible solutions:
- Change icevision code to reference
sahi.models
instead ofsahi.model
, or - Pin
sahi
version to < 0.11.0
To Reproduce Steps to reproduce the behavior:
- Install
icevision
- Try to run
from icevision.all import *
Expected behavior
Icevision modules are imported successfully
Screenshots If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
- OS: Ubuntu 18.04
- Python: 3.9
Additional context Add any other context about the problem here.
Issue Analytics
- State:
- Created a year ago
- Reactions:6
- Comments:5 (1 by maintainers)
Top GitHub Comments
nevermind, there’s already a PR up for this: https://github.com/airctic/icevision/pull/1147/files
I think this requirement needs to be more restrictive so that only up to version 0.10.8 is installed: https://github.com/airctic/icevision/blob/master/setup.cfg#L37