Nebular Login not redirecting if already logged in

Issue type

I’m submitting a … (check one with “x”)

• bug report
• feature request

Issue description

Current behavior: Login component not redirecting if already logged in. For example, you log in, you get redirected to some page, then if you go by url to Login again, you can login again, even if you did not log out and so on (the token is also still there)

Expected behavior: Redirect to success redirect specified page if the user is authenticated

Steps to reproduce: Login, and navigate again to login page and you will be able to login as many times as you wish

Related code:

NbAuthModule.forRoot({
      strategies: [
        NbPasswordAuthStrategy.setup({
          name: 'email',
          token: {
            class: NbAuthJWTToken,
            key: 'my_token'
          },
          baseEndpoint: environment.connectCoreUri,
          login: {
            endpoint: 'api/login',
            method: 'post',
            redirect: {
              success: 'auth/success',
              failure: null,
            },
          }
        }),
      ],
      forms: {},
    })

Other information:

npm, node, OS, Browser

Angular 6 all browsers

Angular, Nebular

Latest version of nebular

[biborn]

@iosif-bancioiu You can definitely solve this by doing a check in your LoginComponent.

In my case, my LoginComponent is extending a class called NbLoginComponent. Thus, my check will be done in ngOnInit function. Here’s how I do it:

import { Component, OnInit } from '@angular/core';
import { NbLoginComponent, NbAuthJWTToken } from '@nebular/auth';

@Component({
  selector: 'app-login',
  templateUrl: './login.component.html',
  styleUrls: ['./login.component.scss'],
})
export class LoginComponent extends NbLoginComponent implements OnInit {
  // no constructor

  ngOnInit() {
    this.service.onTokenChange().subscribe((token: NbAuthJWTToken) => {
      if (token.isValid()) {
        this.router.navigate(['pages/dashboard']); // Your redirection goes here
      }
    });
  }
}

Note that I don’t have to inject anything in the constructor because the parent class (NbLoginComponent) already have everything I need. Hope this helps.

[iosif-bancioiu]

@vikramsparamesh I found a workaround.

1. Login Component

export class LoginComponent extends NbLoginComponent implements OnInit {

 ngOnInit() {
   this.service.onTokenChange().subscribe((token: NbAuthJWTToken) => {
     if (token.isValid()) {
       this.router.navigate(['/auth/success']);
     }
   });
 }

}

1. Auth Module Routing

{
        path: 'success',
        resolve: {
          url: ExternalUrlProviderService,
          skipLocationChange: true
        },
        canActivate: [AuthGuardService], //here do the regular authenticated check
        component: AuthenticatedComponent, //empty component, (something to say redirecting maybe) you need a component here in order for the route to work
}

@NgModule({
  imports: [RouterModule.forChild(routes)],
  exports: [RouterModule],
  providers:[
    {provide: ExternalUrlProviderService, //the service should exist but use value will define what to do in this case
      useValue: () => {
        const externalUrl = environment.URI; //the uri where to redirect if authenticated
        window.open(externalUrl, '_self'); //open in self or new tab
      },}
  ]
})