question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Bug with ExtendedHandshakeMessage.MaxRequests

See original GitHub issue

There is problem with ExtendedHandshakeMessage.MaxRequests because when creating ExtendedHandshakeMessage property MaxRequests not filed by value. And when this message parsed in Mode.HandleExtendedHandshakeMessage property PeerId.MaxSupportedPendingRequests become 1. Then in Mode.PreLogicTick value PeerId.MaxPendingRequests always will be 2 and this make bad effect on download speed.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:6 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
alanmcgoverncommented, Apr 13, 2020

@Jashik Got that patched and merged! Do let me know if it helps performance for you!

@carlosib This may help performance for you too. This change will make MonoTorrent -> MonoTorrent connections better, which is one area you showed an issue.

1reaction
alanmcgoverncommented, Apr 12, 2020

That doesn’t seem good at all! Do you think you could submit a pull request updating the code and adding a new test?

Read more comments on GitHub >

github_iconTop Results From Across the Web

No results found

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found