Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

ConnectionManager.ConnectToPeer creates a PeerId with outdated BitField

See original GitHub issue

Hello. I initialize TorrentManager with MagnetLink. I wait until TorrentManager.Torrent != null. Connected peers have BitField with single element. After some time bitfields are fixed. IgnoringPicker throws on BitField.Check meahwhile. This bug can be fixed in MetadataMode.SwitchToRegular but I am not sure it is a good way.

Issue Analytics

State:
Created 4 years ago
Comments:9 (9 by maintainers)

Top GitHub Comments

1reaction

alanmcgoverncommented, Dec 16, 2019

The extra patch is in now! This should be OK to close now.

Let me know if you have any further issues!

1reaction

alanmcgoverncommented, Dec 11, 2019

Amazing, thanks for checking that so quickly.

I’ll review the usage of the ‘HandshakingPeers’ list as I don’t believe it makes sense to separate these peers from the rest of the ‘ConnectedPeers’. The change went in as part of a large refactor ( https://github.com/mono/monotorrent/commit/b4ee76b33a32698a79bcde8204f4ae328e9da04b ) and there’s no specific reason given for it. I can’t think of any reason why this would be needed.

I’ll merge this change for now so that things are fixed immediately, but i may replace it with an alternative set of changes in the near future!

Thanks!