question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Feature Request] Require Encryption

See original GitHub issue

I would like to see the following feature in 2.0:

new ClientEngine(new EngineSettingsBuilder
{
    RequireEncryption = true
}.ToSettings());

This should behave like other torrent clients do. Don’t connect to a peer that doesn’t support encryption. The added value is that we can be sure that nobody can see the transfer except the receiving peer. Other torrent clients often offer the following options:

  • No Encryption
  • Prefer Encryption
  • Require Encrytion

So perhaps it would be nice to deprecate PreferEncryption in favor of an enum:

new ClientEngine(new EngineSettingsBuilder
{
    EncryptionStyle = EncryptionStyle.Require
}.ToSettings());

enum EncryptionStyle {
  None,
  Prefer,
  Require
}

What do you think?

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:6 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
Deathspikecommented, Dec 18, 2020

Oh! This wasn’t clear to me. I’m now using this as per your suggestion:

new ClientEngine(new EngineSettingsBuilder
{
    AllowedEncryption = EncryptionTypes.RC4Full | EncryptionTypes.RC4Header,
    PreferEncryption = true
}.ToSettings()

I think that dropping PreferEncryption would be better since AllowedEncryption already includes PlainText.

Your suggestion for AllowedEncryption with an order would be ideal for me! I really like that one. 😃

0reactions
Deathspikecommented, Dec 20, 2020

Thanks! Looks good to me!

Read more comments on GitHub >

github_iconTop Results From Across the Web

FEATURE REQUEST: Encrypted Fields
We'd like to request a feature that customers are asking about, and that is the ability to encrypt/secure a specific field with a...
Read more >
Feature request - encryption - FedoraForum.org
Do feature requests belong somewhere else? ... If encryption requires reformatting, then fine, tell me that during the install process.
Read more >
Feature Request: keybase blog posts with selective ...
The visibility for posts would be either 1/ key-signed, but not encrypted, public blog posts (visible to any keybase user), or 2/ encrypted...
Read more >
Require encryption, but not from certain clients (IPs) (feature ...
Currently the workaround for this use case is to set encryption optional, does not allow port 5222 access from outside the firewall, and...
Read more >
Feature Request - SQL Plugin Encryption Repository
Re: Feature Request - SQL Plugin Encryption Repository​​ Our environment contains CJIS, HIPPA and PII data so encryption is required for data in- ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found