Blackout timerange check uses create time, not a current one
See original GitHub issueIssue Summary
The current code changes state of the alert to blackout only if a create time is in the range of blackout. That’s not what users expect. They expect it to transition to blackout if blackout is active now.
Environment
-
OS: Linux
-
API version: 7.4.1
-
Deployment: self-hosted
-
For self-hosted, WSGI environment: nginx/uwsgi
-
Database: [eg. MongoDB, Postgres]
-
Server config: Auth enabled? Yes Auth provider? Basic Customer views? No (or provide the
/config
endpoint output) -
web UI version: any
-
CLI version: any
To Reproduce Steps to reproduce the behavior:
- Create a blackout for a resource which already has open alert(s).
- Alert(s) remain open regardless of an active blackout and received duplicates.
Expected behavior I’d expect all affected alerts changing status to blackout regardless how old these are.
Additional context We are using alertmanager as a main source of alerts an it’s periodically refreshes alerts. All alerts have a timeout set.
Issue Analytics
- State:
- Created 4 years ago
- Comments:18 (16 by maintainers)
Top GitHub Comments
That would work. Plus we would still have history tab to get all info on since when alert is firing.
@sushovan23 Just released as v7.4.5 https://github.com/alerta/alerta/releases/tag/v7.4.5