Review use of pop-ups during OIDC flow
See original GitHub issueIssue Summary
Most other integrations of Azure AD’s OIDC I get redirected and then back. With Alerta’s integration it’s handled via a pop-up which is blocked by default on modern browsers and iOS Safari. I can get around it by going to the browser’s settings and enable pop-ups though.
Environment
-
OS: [eg. Linux, Mac, Windows]
-
API version: [eg. 6.8.1]
-
Deployment: [eg. Docker, Heroku, AWS, GCloud, self-hosted]
-
For self-hosted, WSGI environment: [eg. nginx/uwsgi, apache/mod_wsgi]
-
Database: [eg. MongoDB, Postgres]
-
Server config: Auth enabled? Yes/No Auth provider? Google, GitHub, OpenID, Basic, LDAP, etc Customer views? Yes/No (or provide the
/config
endpoint output) -
web UI version: [eg. 6.8.1]
-
CLI version: [eg. 6.8.1]
To Reproduce Steps to reproduce the behavior:
- Go to ‘…’
- Click on ‘…’ or Run ‘…’
- Scroll down to ‘…’
- See error (include command output)
For web app issues, include any web browser JavaScript console errors.
Expected behavior A clear and concise description of what you expected to happen.
Screenshots If applicable, add screenshots to help explain your problem.
Additional context Add any other context about the problem here.
NOTE: Please provide as much information about your issue as possible. Failure to provide basic details about your specific environment make it impossible to know if an issue has already been fixed, can delay a response and may result in your issue being closed without a resolution.
Issue Analytics
- State:
- Created 4 years ago
- Comments:6 (6 by maintainers)
When the popup was blocked by Firefox and then opened only once without giving permission to open popups automatically, the auth results in a loop and the popup never closes.
Oh, now I get it, it’s because alerta is a single page application and the popup is hardcoded here.