question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

upgrading 1.3.0 -> 1.7.0 regressed several issues

See original GitHub issue

Sadly, upgrading our react-mapbox-gl from 1.3.0 -> 1.7.0 caused several bugs to appear/re-appear for us. Here are the main ones for us:

  • fitBounds property no longer reliable on a page refresh for me; it seems that if the map is loading/rendering (not sure which), fitBounds does not fire properly. However, if I let the map load/stabilize completely and then e.g. navigate to something which creates passes a new fitBounds, it works fine.
  • Map style/layer issues; stuff like layer 'polygon-fill-2584' does not exist in the map's style and cannot be queried for features. This could be because of some workarounds we were using to handle map style changing, but I’m not completely sure.
  • possibly more, i quit looking as hard to deal with these 2 because they are both app-breaking for us.

I’m writing this to remind myself to look at these and see if they are fixable in this repo’s codebase, but also because I want to point out to the community how we probably need some sort of better testing around this to ensure these regressions don’t happen. I am not completely sure how to go about that, because it doesn’t seem like a unit-testing issue as much as integration testing w/ mapbox-gl, but I thought I’d throw it out there.

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:9 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
alex3165commented, Apr 10, 2017

I am sorry for that, anyone would have time to point me to the issue using https://github.com/alex3165/react-mapbox-gl-debug ? Thanks

0reactions
alex3165commented, May 25, 2017

I will close the issue then, I will try to find time this weekend to resolve some issues, thanks everyone for being active on this project it is really nice to see developers using this library.

Read more comments on GitHub >

github_iconTop Results From Across the Web

K8SSAND-483 ⁃ Updating Statefulsets is broken ... - GitHub
I then updated to 1.7.0. cass-operator fails to apply StatefulSet changes. ... We can provide a script to resolve the upgrade issue.
Read more >
Activity - Android Developers
Let us know if you discover new issues or have ideas for improving this library. Please take a look at the existing issues...
Read more >
Warehouse theme changelog - Shopify Themes - Maestrooo
If some new features are absolutely vital for you, the simplest way is to perform a complete upgrade. Click here to learn more...
Read more >
Anthos clusters on VMware release notes - Google Cloud
Fixed a bug where attempting to install or upgrade GKE on-prem 1.7.0 failed with an ... Anthos clusters on VMware 1.3.0-gke.16 is now...
Read more >
Docker Compose release notes | Docker Documentation
Fixed compose#9983; Fixed parsing issue when a container number label is ... Dependencies upgrade: bumped github.com/stretchr/testify from 1.7.0 to 1.7.2.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found