question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Deprecate returning false and friends in favor of promises

See original GitHub issue

The change in https://github.com/alexa-js/alexa-app/pull/133 was backwards compatible, but we may want a major version change that supports only promises and just using:

Promise.resolve(handlerResult).then(res.send).catch(handleError);

We can also remove the return false functionality and make either returning a Promise or calling the callback required in order to send the response (or just call response.send() explicitly).

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Comments:7

github_iconTop GitHub Comments

1reaction
dblockcommented, Feb 17, 2017

Closed via https://github.com/alexa-js/alexa-app/pull/167.

Also @ajcrites you have committer access don’t you. Just do what you think is right and we can argue about it later 😉

0reactions
ajcritescommented, Feb 17, 2017

Can this issue be closed?

Read more comments on GitHub >

github_iconTop Results From Across the Web

For async tests and hooks, ensure "done()" is called
For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. My test code is, I have the...
Read more >
Documentation - TypeScript 4.3
In fact, we've added syntax to interfaces/object types to support ... This condition will always return 'false' since the types 'E' and '-1'...
Read more >
Promise.race() - JavaScript - MDN Web Docs
race () method takes an iterable of promises as input and returns a single Promise . This returned promise settles with the eventual...
Read more >
The Bay of Pigs | JFK Library
"I can assure you," the president promised, "that this flag will be returned to this brigade in a free Havana." The disaster at...
Read more >
6 Functions | Advanced R - Hadley Wickham
Lazy evaluation is powered by a data structure called a promise, or (less commonly) a thunk. It's one of the features that makes...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found