Error validating model even though it is valid

I am getting the following error:

“Provided model ( <model name> ) matched but unitialized or may not contain icon. Refer to https://apple.co/2IhJr0Q, https://apple.co/2Nvshvn and documentation to fill the model correctly.”

After investigating a bit, it seems that the logic in pass.js is as follows:

if (!noDynList.length || !noDynList.some(f => f.toLowerCase().includes("icon"))
    || !remoteFilesList.some(f => f.toLowerCase().includes("icon"))) {
    let eMessage = formatError("MODEL_UNINITIALIZED", path.parse(this.model).name);
    throw new Error(eMessage);
}

This requires me to have an icon both in the noDynList AND the remoteFilesList; surely we only need 1 or the other rather than both?

When I change the code to this it works as I would expect, and I can open the generated pass on my phone:

if (![...noDynList, ...remoteFilesList].some(f => f.toLowerCase().includes("icon"))) {
    let eMessage = formatError("MODEL_UNINITIALIZED", path.parse(this.model).name);
    throw new Error(eMessage);
}

Is my understanding of the expected behavior here wrong? Is the icon actually needed in both lists for some reason?

[alexandercerutti]

Hi, you have to fork the repo with the button above, near Star/Unstar. You’ll get the latest version of the repo available on GitHub. Then you’ll have to apply changes on the new repo, through cloning or via Github Web UI.

Once done, you’ll have to go to Pull Requests > New Pull Request. You’ll get this interface. Click on compare across forks and select yours from the right couple of dropdowns, the left one.

Once the pull request gets merged, if you want, you can delete your fork as repo.

😊

[alexandercerutti]

About your last edit, I think that’s not correct because it would mean that an empty model would still be accepted. 😊

Well, about the NFC, it is a bit a problem for me, as I never tested an NFC pass. As I wrote, I just created the interface to set the properties but never tested. I’ll be happy to try to help you as much as I can.

Thank you!