Misspelled key names
See original GitHub issueCiao @alexandercerutti!
Thank you for this code.
I discovered a little issue: Apple defines the field dictionary key dataDetectorTypes
(plural) as the array of detector names to use (https://developer.apple.com/library/archive/documentation/UserExperience/Reference/PassKit_Bundle/Chapters/FieldDictionary.html#//apple_ref/doc/uid/TP40012026-CH4-SW6).
You define the key as dataDetectorType
(singular): https://github.com/alexandercerutti/passkit-generator/blob/e1c46491d6c685fdb4dd8115fb58b37e479e5425/src/schema.ts#L374
I don’t know if your choice is intentional, but I think that it can lead to some confusion (it took me some time to figure it out).
It’s not a big issue, indeed. But even if it’s not going to be fixed (breaking change!), maybe this note can help someone else.
Issue Analytics
- State:
- Created 2 years ago
- Comments:7 (4 by maintainers)
Top GitHub Comments
Released in
v2.0.7
. Thank you very much!Hmm, I started with this and I finished refactoring all the Schema system 😂
I guess it might take a bit more time because I have to write more tests to check if it is all okay! I’ve added even more missing SemanticsTags.