-r command line option does not work in one instance mode & cudatext opened

When I have "ui_one_instance": true in user.json, opened CudaText with another file and call cudatext -r anotherfile, new file is opened as read-write.

[Alexey-T]

Just added (win32, did not test linux) -z=, -e=, -nh. the same easy way.

[dinkumoil]

@Alexey-T

I’m still too busy in my job to be able to fix that issue by myself but I did a code analysis to give you some hints for fixing it.

BTW: I would classify this issue not as an enhancement but as a bug instead. I was able to figure out that in single-instance-mode the whole command line parsing is reduced to file names, options are ignored as a whole, see below.

Analysis Results

File FormMain.pas contains the following code block (in procedure TfmMain.FormCreate at lines 1840 to 1850):

  {$ifdef windows}
  if IsSetToOneInstance then
    with TInstanceManage.GetInstance do
      case Status of
        isFirst:
          begin
            SetFormHandleForActivate(Self.Handle);
            OnSecondInstanceSentData := @SecondInstance;
          end;
      end;
  {$endif}

In single-instance-mode, after executing line 1847 the main/visible Cud instance is ready to receive data (i.e. command lines sent from subsequently started instances). When data is received, procedure TfmMain.SecondInstance is called (located in file FormMain.pas at line 1720).

The problem is, that TfmMain.SecondInstance checks every command line parameter if it is an existing file and opens it. Thus command line options like -r or even -n are skipped.

To solve the issue, procedure TfmMain.SecondInstance should call the same function that is used for parsing command line arguments. This would be procedure TfmMain.DoOps_LoadCommandLineOptions (located in file formmain_commandline.inc at line 10).

But currently TfmMain.DoOps_LoadCommandLineOptions is called from procedure TfmMain.DoOps_OnCreate (located in file FormMain.pas at line 2038) which in turn is called from TfmMain.OnCreate in line 2031. Furthermore, TfmMain.DoOps_LoadCommandLineOptions operates directly on the ParamStrUTF8 array but it should operate on the command line arguments sent from the subsequently started Cud instance in this case.

That means there has to be implemented some code that stores in single-instance-mode the whole command line of the first started Cud instance and in multi-instance-mode the whole command line of every Cud instance to an array. The same should happen in single-instance-mode in procedure TfmMain.SecondInstance with the command line data sent from a subsequently started Cud instance. Procedure TfmMain.DoOps_LoadCommandLineOptions should operate on that array.

Since procedure TfmMain.DoOps_LoadCommandLineOptions only parses command line options and doesn’t load the provided file(s), there already has to be a piece of code that does that but I haven’t found it. This part of code has to use the array mentioned above as well.