Error in bind_user method

I’m on Python 3.6.3 and I get this exception when I hit line 153 in __init__.py (https://github.com/admiralobvious/flask-simpleldap/blob/master/flask_simpleldap/__init__.py#L153):

AttributeError: 'str' object has no attribute 'decode'

I changed it back to a recent commit you had in v1.1.2, which fixed the issue: conn.simple_bind_s(user_dn, password) (instead of conn.simple_bind_s(user_dn.decode('utf-8'), password))

Can we get that fix back?

[lindycoder]

i crafted a little monkey patch, works for me:

def _monkey_patch_openldap_string_flask_simpleldap_1_2_0_issue_44(ldap_instance):
    import ldap

    def bind_user(self, username, password):
        user_dn = self.get_object_details(user=username, dn_only=True)

        if user_dn is None:
            return
        try:
            if type(user_dn) == bytes:
                user_dn = user_dn.decode('utf-8')

            conn = self.initialize
            conn.simple_bind_s(user_dn, password)
            return True
        except ldap.LDAPError:
            return

    import types
    ldap_instance.bind_user = types.MethodType(bind_user, ldap_instance)

    return ldap_instance

app = Flask(__name__)
# set configs on app
ldap_auth = _monkey_patch_openldap_string_flask_simpleldap_1_2_0_issue_44(LDAP(app))

# use @ldap_auth.*

Have a nice day 😃

[VicenteIranzoMaestre]

Same issue, solved applying @lindycoder code.