Roles functionality

I’m submitting a…

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x ] Feature request
[ ] Documentation issue or request

Current behavior

Although roles can be defined using addRoles, assigning a name and a list of permissions, there appears to be no functionality gained by doing so, that I can see. The permission list is ignored and only the role names are relevant. Perhaps I’m misunderstanding.

Expected behavior

I would expect the ability to assign one or more of the defined roles to the current session and that the relevant permissions would be included in authorization checks such as ngxPermissionsOnly.

Minimal reproduction of the problem with instructions

// Define a role in typescript
this.roleService.addRole('ANALYST', [
            'accessAnalystsSection'
        ]);

// Use the assigned permission from the list in a directive in html
<div *ngxPermissionsOnly="['accessAnalystsSection']">
<p>I have Analyst permission.</p>
</div>

// The above will never be displayed because the permission list defined above is ignored, only the role name is checked in the NgxRolesService.hasRolePermission method

Environment

Angular version: 6.1.6
ngx-permissions version: 6.0.1


Browser:
- [x ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

[troydietz]

@AlexKhymenko Thank you for your response. I think I understand where the confusion is coming from. The way I think I’d use a role is a different from you. In most cases, I would never think of using a role in the ngxPermission directive. Instead, I’d only use permissions.

For example, this is how I imagine using roles and permissions:

<div *ngxPermissions="canViewMessage">
  <div *ngFor="message in messages">
    <span>{{ message }}</span>
    <a *ngxPermissions="canDeleteMessage" (click)="deleteMessage(message)">Delete</a>
  </div>
  <compose-message *ngxPermissions="canPostMessage"></compose-message>
</div>

Possible roles: role: Anonymous, permissions: [canViewMessage] role: User, permissions: [canViewMessage, canPostMessage] role: Admin, permissions: [canViewMessage, canPostMessage, canDeleteMessage]

I can’t think of a time where I’d really want to say *ngxPermissions=“Admin”. And since with ngx-permission you have to load all of the permissions before creating the Admin role, creating the role doesn’t provide me anymore benefit. To be clear, I’m not saying your approach is wrong, I’m just starting to understand why I was confused before. I think you and I think of using roles in slightly different ways.

Thank you very much for your response 😃

[AlexKhymenko]

Thank For all Your patience. Added this functionality + more. Added addRoleWithPermissions, addRolesWithPermissions, flushRolesAndPermissions. Available in 8.1.1. Have a great day 😃