Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Submenu doesn't automatically close when an item is clicked

See original GitHub issue

Issue Description

I noticed that the .menubar-menu-container doesn’t automatically close when any of its .action-menu-item is clicked.

Is there a proper way for this?

I tried: $('menubar-menu-button').removeClass('open') $('.menubar-menu-container').remove()

But since it would still think that the menu is open, I’m getting new issues:

Hovering above the other menu items will open its submenu
The submenu will only open after at least 2 clicks.

Any thoughts?

Issue Analytics

State:
Created 4 years ago
Comments:8 (4 by maintainers)

Top GitHub Comments

1reaction

ahkohdcommented, Jul 23, 2019

Turns out, you don’t need a workaround. This worked but what the heck!

let titleBar = new Titlebar({
    backgroundColor: Color.fromHex('#ECECEC')
});

const menu = new Menu();
menu.append(new MenuItem({
    label: 'Item 1',
    submenu: [
        {
            label: 'Subitem 1',
            click: () => {
                console.log('Click on subitem 1');
                 titlebar.updateMenu(menu);
             }
        },
        {
            type: 'separator'
        }
    ]
}));

titlebar.updateMenu(menu);

Just place titlebar.updateMenu(menu); inside your click handler function, preferably at the end of the function. Weird!

0reactions

jonas-johanssoncommented, Mar 28, 2020

I have this issue in 3.2.2-hotfix62 when clicking a submenu item. So clicking File -> Foo -> Bar executes the click function but the menu stays visible. Clicking File -> Cheese on the other hand executes the click function and closes the menu as expected.