question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Menu without theme doesn't have indicator for refinement

See original GitHub issue

no theme:

screen shot 2018-04-17 at 16 00 26

theme:

screen shot 2018-04-17 at 16 00 37

What if we used strong to indicate that something is refined, as well as maybe something in text (especially for non-sighted users, worst case a aria-label would work, but would prefer visible text)

Issue Analytics

  • State:open
  • Created 5 years ago
  • Comments:9 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
sarahdayancommented, Dec 14, 2022

From a purely behavioral, semantic, and accessible perspective, radio buttons make a lot of sense for menu items.

If InstantSearch was to work without JavaScript (e.g., with a <form> around it and a submit element), we would likely go for either a radiogroup or a listbox. These are accessible by default (no need to manage aria-* attributes ourselves) and provide strong visual cues on which item is selected when there are no styles.

We can always hide the radio buttons in our CSS and keep on bolding the associated label: https://codepen.io/sarahdayanalgolia/pen/KKejJre

I tested the pen above on Firefox, Chrome and Safari, and it seems to work everywhere.

1reaction
samousscommented, Apr 19, 2018

Agree with @Haroenv, even without the style we should have a hint that shows (visually & semantically) that something is currently refined. When I did the migration of IS.css I wasn’t sure that the widget was working without the styling.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Refined - Navigation Menus - Restored 316
Navigate to Dashboard > Appearance > Menus and click on “Manage Locations”. Set the menu from the drop down links next to Above...
Read more >
Adding drop-down menus to your navigation with folders
Use folders to create drop-down navigation menus (also known as nested pages or sub-menus) on your site. Each folder creates a single...
Read more >
Your theme does not support navigation menus or widgets.
Solution: The menu issue caused because of wordpress version (5.9) because not all the themes and plugin are compatible with wordpress 5.9. so...
Read more >
Change Log - Refined for Cloud
Bugfix: Loading indicator fix when entering Refined admin ... Bugfix: Request Type module does not load the Request Type Group when having a...
Read more >
iStat Menus - Bjango
iStat Menus 6.5 is a significant update with design refinements across the entire app, to ensure it feels at home in macOS Big...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found