Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

RFC: more complete connectPagination

See original GitHub issue

Do you want to request a feature or report a bug?

feature

Feature: What is your use case for such a feature?

Currently there’s still a significant amount of code to write if you want to write your own pagination component.

Feature: What is your proposed API entry? The new option to add? What is the behavior?

Deal with the whole clamping, +1 / -1 and padding issue in the connector rather than the view

What is the version you are using? Always use the latest one before opening a bug issue.

2.4.1

Issue Analytics

State:
Created 6 years ago
Reactions:1
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

Haroenvcommented, Jan 30, 2018

IMO that’s very brittle logic that I’d rather have in the connector than in the widget, the one you linked seems like another implementation than the one in IS.js with Pagination.js. for exactly that reason I’d like to have this info in the connector.

I think a good option would be to make a new connector, e.g. unsafe_connectPagination() which we add for now, can be used internally by our IS implementations, or simply adding the extra info under a beta name

1reaction

bobylitocommented, Jan 30, 2018

I’m in! I agree and it fits the ALLAPITV (as little logic as possible in the view) principle 😃 That’s a breaking change though. Maybe a candidate for the v3?