question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

should configure be a connector?

See original GitHub issue

Right now configure is a widget which doesn’t render anything, just like analytics.

PRO:

  • easier when we split up core and widgets
  • other libraries only need to handle connectors (not widgetFactories)

CON:

  • this might imply there’s a value in multiple “kinds” of configure
  • we might need to handle refine

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Reactions:1
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

3reactions
iam4xcommented, Mar 19, 2018

After working with the Configure widget, in order to have it integrated in the angular-instantsearch library I’ll add my +1 to this issue.

Also, @bobylito I think we should use the renderFn if any provided to the widget. I can see a widget with a debug: option where it prints on the page the configure search parameters applied like this:

<pre>
{
	hitsPerPage: 3,
	page: 1
}
</pre>

Also I think we should handle refine function if you want to update the searchParameters applied by Configure on the fly.

1reaction
bobylitocommented, Mar 16, 2018

Things to consider also:

  • a connector for configure (and for analytics) would be artificial because the render will not be used
  • in terms of semantic of the API, the connector is for widget that can be rendered. Implementing the configure as a connector, would change the semantic.

We are the implementors of the libraries so it’s our burden to do the complex stuff so if having configure as widget is only painful for us, then it should not be done if it’s easier for our users to understand as it is. From the pro / con list you made I see difficulties for users to understand the widget / connector, and a burden that we can handle (not too complex).

Read more comments on GitHub >

github_iconTop Results From Across the Web

Do I need to create a connector in Exchange Online?
Before you manually configure connectors, check whether an Exchange hybrid deployment better meets your business needs. For details, see I have ...
Read more >
Configuring Self-Managed Connectors
Connector configurations are key-value mappings. For standalone mode these are defined in a properties file and passed to the Connect process on the...
Read more >
Configure connectors - Operations Manual - Neo4j
How to configure connectors (Bolt, HTTP, and HTTPS) for Neo4j. ... This setting specifies the address that clients should use for this connector....
Read more >
Configuring a connector | FortiSOAR 0.0.0
To configure connectors into FortiSOAR™, you must be assigned a role that has a minimum of Update access to the Connectors module. Prerequisites...
Read more >
Get started - Configure Exchange Online connectors - CodeTwo
You can configure connectors later, either automatically or manually, but keep in mind that email signatures will not be added by the CodeTwo...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found