question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Provide a way to filter out unnecessary preparation

See original GitHub issue

We could provide a way so that scheduled shipjs prepare won’t create unnecessary PRs with meaningless commits.

ref: https://github.com/algolia/shipjs/pull/644

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:9 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
Haroenvcommented, Jan 28, 2020

That sounds like enough info for our use case at least

1reaction
eunjae-leecommented, Jan 29, 2020

Since we have shouldRelease hook (which is not publicly documented, though), I guess shouldPrepare could make sense.

shouldPrepare({ commits, changelog, nextVersion, releaseType, releaseTag, commitNumbersPerType }) {
  /*
    commits: array of strings. `git log --pretty=format:%s` should be fine for this. (only titles)
    changelog: string. only the current version part.
    nextVersion: string.
    releaseType: 'major' | 'minor' | 'patch' | 'prerelease'
    releaseTag: 'latest' | 'alpha' | 'beta' | 'rc' | ... (whatever)
    commitNumbersPerType: { [type]: number } , for example, { 'feat': 10, 'chore': 3, fix: 4 } 
  */
}

In case of git diff, I can’t think of any example using it. It might be too difficult to handle programmatically…? We can add it any time.

What do you think?

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to… Filter - Preppin' Data
A filter in data preparation is the way to make a choice as to whether you want to keep or remove data from...
Read more >
Tips and tricks for filtering your data with Tableau Prep Builder
In this blog, we've included some quick tips and tricks on how to leverage these rich filtering capabilities for your data prep needs....
Read more >
Guidelines and examples for sorting and filtering data by color
Filter and sort data by color to make data analysis easier and help show highlights and data trends at a quick glance.
Read more >
Emergency Water Filters: Guiding You Through the Maze
Providing safe drinking water for your family is one of the most important preparedness priorities. In this post, we are going to focus...
Read more >
To filter or not to filter in HPLC? Now, that's a question. - Cytiva
Why might you not use filtration in HPLC sample prep and in-system, and when is it essential? And how can syringeless filters simplify...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found