[BUG] Interface 'Browser' incorrectly extends interface 'BrowserContext'

Environment

• chrome-aws-lambda Version: 5.2.0
• puppeteer / puppeteer-core Version: 5.2.1
• OS: Mac
• Node.js Version: 12.x
• Lambda / GCF Runtime: nodejs12.x

Expected Behavior

TypeScript should compile without mismatched interface

Current Behavior

Upon compile, it seems interface Browser isn’t typed properly.

node_modules/@types/puppeteer/index.d.ts:1814:18 - error TS2430: Interface 'Browser' incorrectly extends interface 'BrowserContext'.
  The types returned by 'targets()' are incompatible between these types.
    Type 'Promise<Target[]>' is missing the following properties from type 'Target[]': length, pop, push, concat, and 26 more.

1814 export interface Browser extends EventEmitter, TargetAwaiter {

Steps to Reproduce

{
  "devDependencies": {
    "@types/node": "^12",
    "@types/puppeteer": "3.0.1",
    "@typescript-eslint/eslint-plugin": "^3.6.1",
    "@typescript-eslint/parser": "^3.6.1",
    "aws-sdk": "^2.725.0",
    "eslint": "^7.4.0",
    "puppeteer": "^5.2.1",
    "typescript": "^3.9.7"
  },
  "dependencies": {
    "chrome-aws-lambda": "5.2.0",
    "puppeteer-core": "5.2.1"
  }
}

import chromium from "chrome-aws-lambda";
export async function example(): Promise<void> {
  const browser = await chromium.puppeteer.launch({
    executablePath: await chromium.executablePath,
    args: chromium.args,
    defaultViewport: chromium.defaultViewport,
    headless: chromium.headless,
    ignoreHTTPSErrors: true,
  });
}

Possible Solution

I’m honestly not sure if this is a bug or I’m doing something wrong. Please advise.

[benlongmire]

Thanks for the extra info. Unfortunately I haven’t had a chance to look at this.

I’ll be able to spend some limited time on this starting tomorrow (it’s Friday today in Australia).

I’ll let you know how I go ASAP.

[alixaxel]

@benlongmire This should be handled now on the latest version (5.2.1).

The problem is @types/puppeteer is still lagging behind and puppeteer haven’t yet shipped their typings. 🤷🏻‍♂️