The modal insert dialog is hidden although onAddRow returns a string

According to handleSaveBtnClick in Toolbar.js a value/object that is returned by the function assigned to onAddRow in the BootstrapTable options should lead to a notice and the modal not being hidden. This does’t work. The reason is that handleAddRow in BootstrapTable.js does call onAddRow without returning the result. It should look like this:

handleAddRow = newObj => {
 const { onAddRow } = this.props.options;
 if (onAddRow) {
    const colInfos = this.store.getColInfos();
    // JB: Added returning the value that onAddRow returns, to pass it to the caller
    const onAddRowResult = onAddRow(newObj, colInfos);
    if (onAddRowResult) {
       return onAddRowResult;
    }
 } 
  ... 

This ensures that a value/object returned by by the function assigned to onAddRow is passed to handleSaveBtnClick. The fix works in my copy of the BoostrapTable code in a production app without issues. We can even get rid ot the (not working) hack in ToolBar.handleSaveBtnClick:

handleSaveBtnClick = (newRow) => {
 if (!this.validateNewRow(newRow)) { // validation fail
   return;
 }
 const msg = this.props.onAddRow(newRow);
 if (msg) {
   notice('error', msg, '');
   this.clearTimeout();
   // shake form and hack prevent modal hide
   this.setState({
     shakeEditor: true
     // JB: This (not working hack) obviously is not needed (anymore)
     // , validateState: 'this is hack for prevent bootstrap modal hide

[nguyenhose]

Ok, it worked. Thank you so much

[AllenFang]

HI, if you call the callback with explicit string(error message), which means current operation fail so that react-bootstrap-table will not close the modal. But If there’s no any error, you can just call the callback without any arguments, react-bootstrap-table will treat this operation as successful then close the modal.

Let me know if you have any concern.