Screenshots not always attaching to report

I’m submitting a …

• bug report
• feature request
• support request => Please do not submit support request here, see note at the top of this template.

What is the current behavior?

Using allure-cucumber-jvm-3 with screenshots after each step and getting every so often so screenshots attached (suspect a race-condition issue). To get screenshots after each step, using custom class:

public class AllureScreenshotPublisher implements Formatter {
private final AllureLifecycle allureLifecycle;

public AllureScreenshotPublisher() {
    this.allureLifecycle = Allure.getLifecycle();
}

@Override
public void setEventPublisher(EventPublisher publisher) {
    publisher.registerHandlerFor(TestStepFinished.class, this::handleTestStepFinished);
}

private void handleTestStepFinished(final TestStepFinished event) {
    byte[] screenShot = ((TakesScreenshot) DriverManager.getDriver()).getScreenshotAs(OutputType.BYTES);
    allureLifecycle.addAttachment(LocalDateTime.now().format(DateTimeFormatter.ofPattern("dd-MMM-yy_hh:mm:ss")), "image/png", "png", screenShot);
}
}

and then define this as a plugin for each runner:

@CucumberOptions(
glue = {"*.stepdefs"},
features = {"target/parallel/features/[CUCABLE:FEATURE].feature"},
plugin = {"*.allure.AllureScreenshotPublisher",
"io.qameta.allure.cucumber3jvm.AllureCucumber3Jvm"}
)

public class [CUCABLE:RUNNER] extends AbstractTestNGCucumberTests {

}

Any ideas why this fails about 5-10% of the time?

Using: <dependency> <groupId>io.qameta.allure</groupId> <artifactId>allure-cucumber3-jvm</artifactId> <version>2.7.0</version> </dependency>

and Selenium 3.141.59 (if it helps 😃 )

[jsa34]

Hey - I have released the framework as an open source project that we use internally. We fixed this issue by changing the stage at which the screenshots were pushed to be at the “afterStepUpdate” method.

The project is here: (documentation need improving!) https://gitlab.developers.cam.ac.uk/jsa34/selenium-java-framework

Hope this helps!

[jsa34]

Aha - so, now I am using:

@Override
    public void afterStepUpdate(StepResult result) {
            byte[] screenShot = ((TakesScreenshot) DriverManager.getDriver()).getScreenshotAs(OutputType.BYTES);
            Allure.getLifecycle().addAttachment(LocalDateTime.now().format(DateTimeFormatter.ofPattern("dd-MMM-yy_hh:mm:ss")), "image/png", "png", screenShot);
    }

It appears to be fine on a single test, but when I ran the suite in parallel (25 threads) soon after starting, all 25 threads start logging:

04 Jan 2019 14:53:51,330 ERROR [TestNG-test=Surefire test-15] AllureLifecycle:563 - Could not add attachment: no test is running

Once these tests on the threads clear and the next test starts, it appears to no longer be a problem, but those 25 tests that were on the threads at the time that it outed that to the logs had no screenshots attached. Not sure why this is happening? Not enough memory for JVM? Seems odd it affects ALL threads for the duration of the test until a new one is picked up and shortly after the threads are spun up.