enhanceSelectElement always sets autoselect to true

opts.autoselect = opts.autoselect || true

should be

if (opts.autoselect === undefined) opts.autoselect = true

I think

[edwardhorsford]

Reasoning:

We’re setting the default to the most sensible option in each case. For enhanced inputs we need users to be able to type anything, and not have to pick from the list. For selects, users must pick from the list. So the most sensible option is different for each.

The challenge here is to have consistent options, but also an easy way for us to provide ‘recommended’ sets of options. So far we’ve done this by having defaults that offer our recommended options.

My concern with changing this default is that we’ll see most users of this component not using autoselect- a feature we’ve found to be very beneficial. I’m very open to alternate suggestions that achieve this though, and agree the inconsistency is awkward.

[joelanman]

this was fixed by #167