question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add thousands comma-seperation in character count messages

See original GitHub issue

Related component

Character count

Context

The current GDS content style guide states:

For numerals over 999 - insert a comma for clarity: 9,000

…however the information/error message (when over 999 characters) does not include comma separation.

Example entering 1200 characters in the Design System documentation page: image

The expected message in this case would beYou have 1,000 characters too many

Alternatives

None found yet, but we are considering adding some custom JS to our service. This would modify the comma-seperation message output for screens which use Character Count component.

Additional information (if applicable)

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:9 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
querkmachinecommented, Sep 15, 2022

Reopened as was closed in error. The underlying functionality needed for this to work has been completed, but the actual changes to the character count component will happen as part of #2701 and #2805.

1reaction
vanitabarrettcommented, Jun 28, 2022

Another alternative (if there’s nothing left to do on this other than release i18n) could be to attach this to a Github milestone and move the card to Ready To Release. I think it’ll sit there for a while, but that might be ok?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Thousand separator using COUNT values
I have two tables: One displaying the SUM of values, the other the count of values. I can only manage to show thousand...
Read more >
Help-Thousand comma separator in number
Dear Community, I have achieved adding comma for thousand value which is working fine in powerapps. However, this is only for display ...
Read more >
How to format a number with commas as thousands separators?
This solution uses dots for thousands separators and comma for the precision. ... This is the position where a word character is not...
Read more >
Add thousands separator in a number - Unix Stack Exchange
A common use case for me is to modify the output of a command pipeline so that decimal numbers are printed with thousand...
Read more >
Formatting a number with thousand separators - SQLMatters
This works by using the CONVERT function to convert the number from MONEY to a VARCHAR with a style of 1, which adds...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found