question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Investigate simplifying the update process - application.scss

See original GitHub issue

What

There are 4 steps to update application.scss (steps 4 - 7): https://govuk-prototype-kit.herokuapp.com/docs/updating-the-kit

We could replace the relevant lines in application.scss with a single import for all of ‘our stuff’, so in future users don’t have to do this manually.

Why

This significantly simplifies the update process, making it quicker and more reliable

Who needs to work on this

  • Developers
  • Content Designer

Who needs to review this

  • Developers
  • Content Designer

Done when

  • Investigate existing prototypes and how they have edited application.scss
  • Investigate replacing the section in application.scss with a single import
  • Implement if sensible

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:8 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
joelanmancommented, Jun 9, 2022

agree, though this has been the ‘api’ for a long time, so I think it would be ok to break it and support users who put their own code above that line to fix it

1reaction
joelanmancommented, Jun 9, 2022

If there was an update guide, I don’t think this would be a breaking change. I think we’d need to consider adding something to the update script, otherwise we’d have to include these steps for anyone who hasn’t updated to the new method. And we’d probably have to complicate the steps even further (“If you’re on version X…”)

Read more comments on GitHub >

github_iconTop Results From Across the Web

editing scss files doesn't seem to update styles on page #326
The gulp file seems to update the '.tmp/styles/*' files correctly, but the reload doesn't then use these files. Simple example, deleting the ...
Read more >
The definitive guide to SCSS - LogRocket Blog
In this guide, we'll demonstrate how to use SCSS — think of it as a way to write CSS with superpowers. I've broken...
Read more >
Sass Basics
Once Sass is installed, you can compile your Sass to CSS using the sass command. You'll need to tell Sass which file to...
Read more >
Import regular CSS file in SCSS file? - sass - Stack Overflow
I just want to point out that as December 2014, this issue has been resolved. It is now possible to import css files...
Read more >
Using SASS and Compass in ASP.Net MVC with Web ...
Compass is an open source Ruby application that extends the features of SASS. Compass simplifies the use of popular CSS design patterns through ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found