question-mark

Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

contentWrapper breaks CSS rules and videos

See original GitHub issue

Issue Description

Hi,

I’ve this strange behavior when integrating TarteAuCitron : my <video> on homepage is frozen and some CSS rules are broken…

I’ve finally found a culprit : div#contentWrapper that embeds all html of the body by TarteAuCitron… Is the only reason of that wrapper the aria-hidden attribute ?

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:9 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
stevenMouretcommented, Oct 3, 2018

The best way is to not use aria-hidden but a dialog role.

Here the Dialog (modal) design pattern. And an example.

1reaction
rubyconcommented, Oct 3, 2018

La solution proposée par @alterphp est simple et sans inconvénients. Par contre je pense qu’utiliser un data attribute au lieu d’une classe (element.dataset['tarteaucitron-hidden'] = true;) pour identifier les éléments modifiés serait moins invasif.

Cependant la fonctionnalité d’accessibilité devrait aussi être modifiable depuis tarteaucitron.init().

Read more comments on GitHub >

github_iconTop Results From Across the Web

Content Jumping (and How To Avoid It) | CSS-Tricks
I would argue that shifting the page layout after the initial render (without relevant user interaction) may be the single most unpleasant user ......
Read more >
Wrapping and breaking text - CSS: Cascading Style Sheets
Wrapping and breaking text. This guide explains the various ways in which overflowing text can be managed in CSS.
Read more >
content wrapper breaking my html after porting header and ...
I know that my wrapper container div is causing my html to break in my header.php file (see here for live site.
Read more >
Can CSS force a line break after each word in an element?
You need to define a width to your parent wrapper or your content wrapper. The text-fix is working hence bringing your next word...
Read more >
Full Width Video - Customize with code - Squarespace Forum
Add to Home > Design > Custom CSS /* fullwidth home video block */ body.homepage #page section:first-child .content-wrapper { padding: 0 ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found