Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

🌸 Cherry-pick request for #30188,#30167 into #30086 (Pending)

See original GitHub issue

Cherry-pick request

Issue	PR	Beta / Experimental?	Stable?	LTS?	Release issue
https://github.com/ampproject/amphtml/issues/27036,	https://github.com/ampproject/amphtml/pull/30188, #30167	NO	NO	YES	#30086

Why does this issue meet the cherry-pick criteria?

in certain situations, amp components that use the owners system (carousel, amp-list) fail to render.
in certain situations, amp components using layout=fill fail to render.

Why is a Beta / Experimental cherry-pick not needed?

The fix is already in Beta/Experimental

Why is an LTS cherry-pick needed?

The bug was merged on aug 7th, LTS was cut from code on aug 29th.

Mini-postmortem

TODO: This postmortem will be written after the cherry-pick deployment and before this issue is closed. Delete this TODO when the postmortem is ready.

Summary

Issue with intersect-resources experiment where it can use an out-of-date rect. Specifically we were seeing a regression in amp-ad where a carousel 1.0 slides were not being laid out at all. This is due to a mismatch in isDisplayed between the premeasure rect and the more-recent measure within owners.

Impact

Users of amp-carousel 1.0
Users of amp-iframe

Action Items

#<ISSUE_NUMBER>: (TODO)

/cc @ampproject/release-on-duty @ampproject/wg-approvers @ampproject/cherry-pick-approvers @jridgewell

Issue Analytics

State:
Created 3 years ago
Comments:15 (14 by maintainers)

Top GitHub Comments

1reaction

Enriqecommented, Oct 1, 2020

New LTS with CPs is live. @samouri please verify the fix is in and close this issue when PM is complete.

0reactions

samouricommented, Oct 1, 2020

Was able to fully confirm the layout=fill bug is fixed and partially that the owners system bug is fixed test pages. The reason I couldn’t fully confirm the owners bug was because one of the test ads looks like its no longer valid (the repro case called out in https://github.com/ampproject/amphtml/pull/30188).

EDIT: was able to verify both fixes. I believe one of them doesn’t work on my machine since I’m at a hotel with weird router rules (many sites don’t load properly).