Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

🌸 Cherry-pick request for #35639 into #2107302322000 & 2108052321000

See original GitHub issue

Channels

Stable

Formats

Stories

Justification

Web stories do not load on iPad Safari and the following error is thrown: Screen Shot 2021-08-12 at 11 17 58 AM The same error is thrown on iOS and dekstop however the experience does not break. This CP will also fix the error being thrown.

Verification Steps

Open any story on iPad Safari.
Verify that the story loads.

Summary

A null check is added to the orientation property on the screen object. Accessing this property is the root cause of the bug.

Impact

All users viewing a web story on iPad Safari were effected.

Action Items

Safari on iPads is different than on iPhones. Because of this we recommend manual iPad testing to be part of the weekly testing routine.

Notifications

/cc @ampproject/release-on-duty @ampproject/wg-approvers @ampproject/cherry-pick-approvers

Issue Analytics

State:
Created 2 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

2reactions

processprocesscommented, Aug 13, 2021

The fix is verified in prod and beta. The Illegal invocation error is still throwing in Chrome desktop but it doesn’t appear to be breaking the experience. Screen Shot 2021-08-13 at 10 27 44 AM I’ll look into fixing that in a separate PR. Filed #35659 for tracking