question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add option to keep the linker for exact domain matches

See original GitHub issue

Description

The Don’t append linker for exact domain match PR can affect tracking in situations where more platforms use the same domain. The request is to provide a way to opt-out of this behaviour.

Ex: In the case of WordPress.com, the linker is used to transition from the AMP Landing Pages to Calypso; which are 2 platforms with the same domain. After the linker removal for exact domain match, this transition is broken.

Alternatives Considered

Having a noInternalLinking would allow us to opt-out of the changes from the PR and go back to the previous behaviour.

Additional Context

The noInternalLinking solution has been brought up in other discussions as well: https://github.com/ampproject/amphtml/pull/32100#issuecomment-772901579 https://github.com/ampproject/amphtml/issues/30176#issuecomment-765730810

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Reactions:2
  • Comments:13 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
micajuine-hocommented, Jun 10, 2021

@claudiucelfilip Took this question to Design review yesterday. The team agreed that we can support this. I will work on making the changes with a new opt in API.

1reaction
ekatyshevacommented, Jun 3, 2021

I think so. I don’t deeply undestand what is going on when linking is working (though I’ve tried to read docs many times), but e.g. this portion of configuration

 "linkers": {
   "enabled": true,
   "proxyOnly": false,
   "destinationDomains": ["*.ourdomain.com"] // we have several subdomains for staging/prod
 },

helped me to link sessions between AMP and non-AMP pages with google analytics. It was done quite some time ago and I found out just today that this behaviour is broken when tried to do so with amplitude.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Analytics: gtag domain linker adds _gl query parameter even ...
I can see two issues here. 1, the destinationDomain is set to weston.ruter.net . By default, AMP won't decorate a url with the...
Read more >
Google Analytics Cross Domain tracking with Google Tag ...
A comprehensive guide to Google Analytics Cross-domain tracking and how to configure it with the help of Google Tag Manager.
Read more >
Conversion linker - Tag Manager Help - Google Support
Conversion linker tags are used to help tags measure click data so that conversions are measured effectively. Deploy a conversion linker tag on...
Read more >
#GTMTips: Auto Link Domains With Regex | Simo Ahava's blog
In the domainList array, you need to add all the domains you want to automatically link separating each value with a comma. You...
Read more >
Cross Domain Tracking in GA4 (Google Analytics 4) Setup ...
This helps to keep user counts more accurate and give you a complete ... In the case of Google Analytics 4 setting up...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found